jonah/mini-graph-card
1
0
Fork 0
mirror of https://github.com/kalkih/mini-graph-card.git synced 2025-12-20 00:35:56 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: tooltip interval start could be after end (#1065)

Browse Source 
* basically: use milliseconds in constants rather than fractions of hours
* also remove strange interval size of n_points if hours < 1 and points/hour < 1
* also use 1 minute offset for end only when group_by, because that is cosmetics actually

fixes #181
This commit is contained in:
akloeckner
2024-01-28 17:31:45 +01:00
committed by GitHub
parent af3d02e7c6
commit 930ee39f51
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/main.js
View File

@@ -527,27 +527,34 @@ class MiniGraphCard extends LitElement {
setTooltip(entity, index, value, label = null) {
const {
group_by,
points_per_hour,
hours_to_show,
format,
} = this.config;
const offset = hours_to_show < 1 && points_per_hour < 1
? points_per_hour * hours_to_show
: 1 / points_per_hour;
const id = Math.abs(index + 1 - Math.ceil(hours_to_show * points_per_hour));
// time units in milliseconds in this function
const interval = getMilli(1 / points_per_hour);
const n_points = Math.ceil(hours_to_show * points_per_hour);
// index is 0 (oldest) to n_points-1 (most recent ~= now)
// count of intervals from now to end of bin
// count is 0 (now) to n_points-1 (oldest)
const count = (n_points - 1) - index;
// offset end by a minute, if grouped by, e.g., date or hour
const oneMinute = group_by !== 'interval' ? 60000 : 0;
const now = this.getEndDate();
const oneMinInHours = 1 / 60;
now.setMilliseconds(now.getMilliseconds() - getMilli(offset * id + oneMinInHours));
now.setMilliseconds(now.getMilliseconds() - oneMinute - interval * count);
const end = getTime(now, format, this._hass.language);
now.setMilliseconds(now.getMilliseconds() - getMilli(offset - oneMinInHours));
now.setMilliseconds(now.getMilliseconds() + oneMinute - interval);
const start = getTime(now, format, this._hass.language);
this.tooltip = {
value,
id,
count,
entity,
time: [start, end],
index,