jonah/openbao
1
0
Fork 0
mirror of https://github.com/openbao/openbao.git synced 2026-02-07 00:45:54 +01:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Do not set LimitNOFILE (#1179)

Browse Source 
* Do not set LimitNOFILE

This is not needed anymore since https://github.com/golang/go/issues/46279 was resolved. 

Quoting https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#Process%20Properties

> **Don't use.** Be careful when raising the soft limit above 1024, since select(2) cannot function with file descriptors above 1023 on Linux. Nowadays, the hard limit defaults to 524288, a very high value compared to historical defaults. Typically applications should increase their soft limit to the hard limit on their own, if they are OK with working with file descriptors above 1023, i.e. do not use select(2). Note that file descriptors are nowadays accounted like any other form of memory, thus there should not be any need to lower the hard limit. Use MemoryMax= to control overall service memory use, including file descriptor memory.

Signed-off-by: Arian van Putten <arian.vanputten@gmail.com>

* Add changelog entry

Signed-off-by: Alexander Scheel <ascheel@gitlab.com>

---------

Signed-off-by: Arian van Putten <arian.vanputten@gmail.com>
Signed-off-by: Alexander Scheel <ascheel@gitlab.com>
Co-authored-by: Alexander Scheel <ascheel@gitlab.com>
This commit is contained in:
Arian van Putten
2025-04-10 19:27:22 +02:00
committed by GitHub
parent dd49a1fcdb
commit 2360c12d8b
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.release/linux/package/usr/lib/systemd/system/openbao.service
View File

@@ -26,7 +26,6 @@ KillSignal=SIGINT
Restart=on-failure
RestartSec=5
TimeoutStopSec=30
LimitNOFILE=65536
MemorySwapMax=0
[Install]

3
changelog/1179.txt Normal file
View File

@@ -0,0 +1,3 @@
```release-note:change
packaging/systemd: Do not set LimitNOFILE, allowing Go to automatically manage this value on behalf of the server. See also https://github.com/golang/go/issues/46279.
```