Change shellcheck and checkbashism triggers.

Newer versions of `shellcheck` and `checkbashism` finds more than
previous, so fix those.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Turbo Fredriksson <turbo@bayour.com>
Closes #18000

contrib/initramfs/scripts/zfs

@@ -446,7 +446,7 @@ decrypt_fs()
 		echo "${ENCRYPTIONROOT}" > /run/zfs_fs_name
 
 		# If root dataset is encrypted...
-		if ! [ "${ENCRYPTIONROOT}" = "-" ]
+		if [ "${ENCRYPTIONROOT}" != "-" ]
 		then
 			KEYSTATUS="$(get_fs_value "${ENCRYPTIONROOT}" keystatus)"
 			# Continue only if the key needs to be loaded
@@ -465,7 +465,7 @@ decrypt_fs()
 			done
 
 			# Do not prompt if key is stored noninteractively,
-			if ! [ "${KEYLOCATION}" = "prompt" ]
+			if [ "${KEYLOCATION}" != "prompt" ]
 			then
 				"${ZFS}" load-key "${ENCRYPTIONROOT}"
 

scripts/paxcheck.sh

@@ -10,7 +10,7 @@ RET=0
 # check for exec stacks
 OUT=$(scanelf -qyRAF '%e %p' "$1")
 
-if [ x"${OUT}" != x ]; then
+if [ "${OUT}" != "" ]; then
     RET=2
     echo "The following files contain writable and executable sections"
     echo " Files with such sections will not work properly (or at all!) on some"
@@ -26,7 +26,7 @@ fi
 # check for TEXTRELS
 OUT=$(scanelf -qyRAF '%T %p' "$1")
 
-if [ x"${OUT}" != x ]; then
+if [ "${OUT}" != "" ]; then
     RET=2
     echo "The following files contain runtime text relocations"
     echo " Text relocations force the dynamic linker to perform extra"