jonah/zfs
1
0
Fork 0
mirror of https://github.com/openzfs/zfs.git synced 2025-12-19 05:05:52 +01:00
Code Issues Actions 20 Packages Projects Releases Wiki Activity

ZTS: Fix zvol_misc_fua SLOG writes check

Browse Source 
Instead of comparing number of SLOG writes to number of normal
writes we should just make sure SLOG got the required number of
writes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes #18033
This commit is contained in:
Alexander Motin
2025-12-10 14:28:00 -05:00
committed by Brian Behlendorf
parent 20f09eae42
commit d976587a35
1 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/zfs-tests/tests/functional/zvol/zvol_misc/zvol_misc_fua.ksh
View File

@@ -73,7 +73,6 @@ function do_test {
block_device_wait $zvolpath
# Write using sync (creates FLUSH calls after writes, but not FUA)
old_vdev_writes=$(get_sync $DISK1)
old_log_writes=$(get_sync $datafile3)
log_must fio --name=write_iops --size=5M \
@@ -81,20 +80,13 @@ function do_test {
--iodepth=1 --rw=randwrite --group_reporting=1 \
--filename=$zvolpath --sync=1
vdev_writes=$(( $(get_sync $DISK1) - $old_vdev_writes))
log_writes=$(( $(get_sync $datafile3) - $old_log_writes))
# When we're doing sync writes, we should see many more writes go to
# the log vs the first vdev. Experiments show anywhere from a 160-320x
# ratio of writes to the log vs the first vdev (due to some straggler
# writes to the first vdev).
#
# Check that we have a large ratio (100x) of sync writes going to the
# log device
ratio=$(($log_writes / $vdev_writes))
log_note "Got $log_writes log writes, $vdev_writes vdev writes."
if [ $ratio -lt 100 ] ; then
log_fail "Expected > 100x more log writes than vdev writes. "
# When doing sync writes, we should see at least one SLOG write per
# block (5MB / 4KB) == 1280.
log_note "Got $log_writes log writes."
if [ $log_writes -lt 1280 ] ; then
log_fail "Expected >= 1280 log writes. "
fi
# Create a data file